Skip to content

first and last color of cyclicals should match #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Conversation

nicolaskruchten
Copy link
Contributor

No description provided.

@nicolaskruchten
Copy link
Contributor Author

Without this fix:

image

With this fix:

image

@nicolaskruchten
Copy link
Contributor Author

Note that the last two look markedly better, and the other ones that changed don't look all that different, because the last color didn't change all that much.

@emmanuelle
Copy link
Contributor

Looks good ! Ideally we would document the new cyclical swatches function but maybe it should go instead to a new "colors" page of the documentation (I think you mentioned it previously). Maybe open an issue to remember that we need to document this? But this should not block the PR, so 💃

@nicolaskruchten
Copy link
Contributor Author

I've just added this page in doc-prod https://plot.ly/python/builtin-colorscales/ so I'll update this PR to expand that page a bit :)

@nicolaskruchten nicolaskruchten mentioned this pull request Jan 4, 2020
@nicolaskruchten nicolaskruchten added this to the v4.5.0 milestone Jan 9, 2020
@nicolaskruchten nicolaskruchten merged commit 5ac8f55 into master Jan 15, 2020
@nicolaskruchten nicolaskruchten deleted the cyclical_fix branch June 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants